Full coverage for role_request, user, sms services

📄 Description: The files app/services/role_request_service.py, app/services/sms_service.py, and app/services/user_service.py currently have test coverage between 81% and 86%, leaving portions of business logic, conditional branches, and exception handling untested. This increases the risk of undetected bugs and reduces confidence in the stability of these core service modules. This issue focuses on improving the test coverage to 100% by adding comprehensive unit tests that cover all execution paths.

📊 Current State Coverage:

role_request_service.py → 81%

sms_service.py → 86%

user_service.py → 83%

🎯 Objective: Achieve 100% test coverage across all three service files.

✅ Scope of Work:

• Add unit tests for all functions in all three files
• Test exception handling scenarios
• Include edge cases (null, empty, invalid inputs, duplicates, unauthorized access)
• Mock external dependencies (DB, APIs like SMS services)
• Ensure no uncovered lines remain

🧪 Testing Approach:

• Use pytest
• Use mocking (unittest.mock / pytest-mock)
• Validate both success and failure scenarios
• Trigger exception paths using mocks
• Ensure tests are isolated and deterministic

📌 Acceptance Criteria:

• Coverage reaches 100% for all three files
• All functions are tested
• No missing lines in coverage report
• Tests are clean and maintainable

🚀 Expected Outcome:

• Improved code reliability
• Reduced risk of bugs
• Better confidence for future changes